Conversation
…ring Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rkflow code editor Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes workflow editor property input behavior when clearing date/datetime/time values, and aligns the workflow code editor close button sizing with other header buttons.
Changes:
- Coerce cleared DATE/DATE_TIME/TIME property values from
''tonullbefore saving. - Adjust
<input type="time">step to minute precision and add/extend tests for the new behaviors. - Update WorkflowCodeEditorSheet close button sizing/styling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/pages/platform/workflow-editor/components/properties/hooks/useProperty.ts | Adds resolvedValue logic to save null for cleared date/time controls. |
| client/src/pages/platform/workflow-editor/components/properties/hooks/tests/saveInputValueResolvedValue.test.ts | Adds unit coverage for the date/time empty-string-to-null save coercion. |
| client/src/pages/platform/workflow-editor/components/properties/components/property-input/PropertyInput.tsx | Sets step=60 for time inputs to enforce minute precision. |
| client/src/pages/platform/workflow-editor/components/properties/components/property-input/PropertyInput.test.tsx | Adds tests asserting step behavior for time vs non-time inputs. |
| client/src/pages/platform/workflow-editor/components/WorkflowCodeEditorSheet.tsx | Updates the close button icon sizing and button size variant to match header peers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.